Update govuk-main-wrapper object and add a large varient
#602
Conversation
|
Nice approach. Is this useful across services or just for us on the design system? Edit: Misunderstood this, nevermind, makes sense. |
|
Definitely a good approach. Did some testing (captures below). I'm wandering if we should have the page title vertically aligned regardless of having or not a back-link on the page (i.e. when a service has the back button only on some pages to have the title in the same y-axis location) - not sure is a common scenario. Otherwise I'm happy for this to get merged.
|
| // | ||
| // Example usage without Breadcrumbs, phase banners, back links: | ||
| // <div class="govuk-o-width-container"> | ||
| // <div class="govuk-o-main-wrapper--l"> |
There was a problem hiding this comment.
Modifiers (--) should always be used with the classes that they are modifying – in which case this would be class="govuk-o-main-wrapper govuk-o-main-wrapper--l".
| // Use govuk-main-wrapper--l when you page does not have Breadcrumbs, phase banners or back links | ||
| @mixin govuk-main-wrapper--l { | ||
| @include govuk-responsive-padding($govuk-spacing-responsive-8, "top"); | ||
| @include govuk-responsive-padding($govuk-spacing-responsive-8, "bottom"); |
There was a problem hiding this comment.
Not sure why the presence (or absence) of breadcrumbs / back links would affect the padding at the bottom of the page – should this still be responsive-6?
dashouse
force-pushed
the
update-main-wrapper-object
branch
from
8cdbfed
to
75aca16
Compare
|
I've fixed @36degrees 's issues. I've messed up these commits slightly I think, had some issues with a rebase on the CHANGELOG |
dashouse
changed the title
govuk-main-wrapper object and add a large varientgovuk-main-wrapper object and add a large varient
dashouse
force-pushed
the
update-main-wrapper-object
branch
from
3033892
to
7598562
Compare
alex-ju
force-pushed
the
update-main-wrapper-object
branch
from
7598562
to
c383c3b
Compare
Update to use the responsive spacing mixin and add a large variant for use when the page does not contain back links or breadcrumbs
alex-ju
force-pushed
the
update-main-wrapper-object
branch
from
c383c3b
to
205e3d0
Compare
|
Merged |
This PR:
govuk-main-wrapperclass to use the responsive spacing mixin, rather than the fixed spacing scale with media queries.govuk-main-wrapper(govuk-main-wrapper--l) for use on pages where there is no Back link, Breadcrumb or Phase banner. This applies some more space to the top and bottom of the page.With breadcrumb
Without breadcrumb (standard
govuk-main-wrapperWithout breadcrumb (using
govuk-main-wrapper--l)