Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure render function does not have undefined object #587

Merged
merged 3 commits into from
Mar 8, 2018
Merged

Ensure render function does not have undefined object #587

merged 3 commits into from
Mar 8, 2018

Conversation

NickColley
Copy link
Contributor

No description provided.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-587 March 8, 2018 11:03 Inactive
@NickColley NickColley force-pushed the ensure-render-function-does-not-have-undefined-object branch from e981b5f to ca267e2 Compare March 8, 2018 11:03
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-587 March 8, 2018 11:03 Inactive
@kr8n3r
Copy link

kr8n3r commented Mar 8, 2018 •
edited
Loading

don't all components need const $ = render('<component>', {}) change made?

nevermind, i see it

@NickColley
Guard render function from empty objects
9601d91 
This has caught me out a few times, it's easy to pass an undefined example,
then wonder why nothing is working.
@NickColley
Update tests to avoid passing undefined parameters
243c453
@NickColley
Update changelog
af0c9a2
@NickColley NickColley force-pushed the ensure-render-function-does-not-have-undefined-object branch from ca267e2 to af0c9a2 Compare March 8, 2018 11:49
kr8n3r
kr8n3r approved these changes Mar 8, 2018
View reviewed changes
Copy link

@kr8n3r kr8n3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@NickColley NickColley merged commit 06312a6 into master Mar 8, 2018
@NickColley NickColley deleted the ensure-render-function-does-not-have-undefined-object branch March 8, 2018 12:15
@NickColley NickColley mentioned this pull request Mar 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kr8n3r kr8n3r kr8n3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickColley @kr8n3r @govuk-design-system-ci