Nest components correctly #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-584
NickColley
force-pushed
the
nest-components-correctly-2
branch
from
a47a0c1
to
1efae42
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-584
|
@igloosi yeah I think so, I was being cheeky and hoping I could sneak it in this one. |
|
:) |
|
Okay, okay, I'll split it out 👼 |
NickColley
force-pushed
the
nest-components-correctly-2
branch
from
1efae42
to
95d8ae3
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-584
|
thanks, just the chnagelog left |
Ensure that components are nested in the right way.
NickColley
force-pushed
the
nest-components-correctly-2
branch
from
95d8ae3
to
47c8eaa
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-584
NickColley
force-pushed
the
nest-components-correctly-2
branch
from
47c8eaa
to
349826d
Compare
kr8n3r
approved these changes
Mar 8, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #531
Best viewed commit by commit.
For the README generation commit you might want to use this link with whitespace removed from the diff: 1efae42?w=1