Allow input type to be overridden; Update date input to use type="number" #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-568
This matches the existing behaviour in GOV.UK Elements [1]. As documented there, the `pattern` attribute is not valid HTML for inputs where the `type` attribute is `number`, but we add it anyway to force numeric keypads on iOS devices. [1]: https://github.com/alphagov/govuk_elements/blob/5b6dc246861dbd2e821e62d153e6eb962830e1af/app/views/examples/example_date.html [2]: http://bradfrost.com/blog/mobile/better-numerical-inputs-for-mobile-forms
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-568
|
I have the same concerns here as with the |
|
From memory, Nothing happens if a user types a non-numeric character, but I wonder if this is actually a problem in reality - it may help users catch issues quicker - and it's standard browser behavior. |
|
This is just aligning Frontend with what we already have in Elements. |
|
This needs an addition to the changelog @36degrees |
36degrees
added a commit
that referenced
this pull request
Mar 6, 2018
These represent the changes from #568 – we accidentally omitted updating the changelog as part of that PR.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.
https://trello.com/c/gpdeKWhm/695-make-date-input-component-use-typenumber