Fix incorrect selector in 'section break' #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-547
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-547
NickColley
approved these changes
Feb 23, 2018
The visible class is a modifier and so should be separated from the block using double dashes (--) rather than double underscores (__) which signifies an element.
36degrees
force-pushed
the
fix-section-break-visible-selector
branch
from
47f3abc
to
aa77e8c
Compare
|
Rebased to resolve merge conflict in changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The visible class is a modifier and so should be separated from the block using double dashes (--) rather than double underscores (__) which signifies an element.