Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service navigation mobile toggle spacing #5278

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Fix service navigation mobile toggle spacing #5278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ For advice on how to use these release notes see [our guidance on staying up to

## Unreleased

### Fixes

We've made fixes to GOV.UK Frontend in the following pull requests:

- [#5278: Fix service navigation mobile toggle spacing](https://github.com/alphagov/govuk-frontend/pull/5278)

## v5.6.0 (Feature release)

To install this version with npm, run `npm install [email protected]`. You can also find more information about [how to stay up to date](https://frontend.design-system.service.gov.uk/staying-up-to-date/#updating-to-the-latest-version) in our documentation.
Expand Down
8 changes: 7 additions & 1 deletion packages/govuk-frontend/src/govuk/components/service-navigation/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
.govuk-service-navigation__toggle {
@include govuk-font($size: 19, $weight: bold);
display: inline-flex;
margin: 0 0 govuk-spacing(2);
margin: govuk-spacing(2) 0;
padding: 0;
border: 0;
color: $govuk-service-navigation-link-colour;
Expand All @@ -117,6 +117,12 @@
&[hidden] {
display: none;
}

// If we have both a service name and navigation toggle, remove the
// margin-top so that there isn't a bunch of space between them
.govuk-service-navigation__service-name + .govuk-service-navigation__wrapper & {
margin-top: 0;
}
}

.govuk-service-navigation__list {
Expand Down