Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for checkboxes macro #513

Merged
merged 3 commits into from
Feb 8, 2018
Merged

Add tests for checkboxes macro #513

merged 3 commits into from
Feb 8, 2018

Conversation

alex-ju
Copy link
Contributor

@alex-ju alex-ju commented Feb 8, 2018

This PR:

  • Adds tests to checkboxes component to ensure the markup is rendered correctly when providing arguments to the macro;
  • Updates CHANGELOG.MD.

Trello Card

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-513 February 8, 2018 11:36 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-513 February 8, 2018 11:37 Inactive
NickColley
NickColley reviewed Feb 8, 2018
View reviewed changes
src/components/checkboxes/template.test.js
expect($firstInput.attr('disabled')).toEqual('disabled')
})

it('render checked', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we maybe increase this example to have three inputs and check that two inputs can be checked at one time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Done.

@alex-ju alex-ju force-pushed the add-tests-for-checkboxes-macro branch from 7e6af23 to b7f8bf8 Compare February 8, 2018 12:35
NickColley
NickColley approved these changes Feb 8, 2018
View reviewed changes
Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Alex 💯

@alex-ju alex-ju merged commit dea8c9b into master Feb 8, 2018
@alex-ju alex-ju deleted the add-tests-for-checkboxes-macro branch February 8, 2018 14:56
@alex-ju alex-ju mentioned this pull request Feb 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickColley NickColley NickColley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-ju @NickColley @govuk-design-system-ci