-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant tag CSS from phase banner #5090
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The phase banner uses the tag component, which takes care of doing this for us since 976535e (part of #3502): https://github.com/alphagov/govuk-frontend/blob/3822ac1bd000d0f965d3cece2716df91641b82cd/packages/govuk-frontend/src/govuk/components/tag/_index.scss#L32-L40
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 3d84c82 |
Stylesheets changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css b/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
index fd84364d2..ceac53d84 100644
--- a/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
+++ b/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
@@ -4833,12 +4833,6 @@ only screen and (min-resolution:2dppx) {
}
}
-@media screen and (forced-colors:active) {
- .govuk-phase-banner__content__tag {
- font-weight: 700
- }
-}
-
.govuk-phase-banner__text {
display: table-cell;
vertical-align: middle
Action run for 3d84c82 |
Other changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/components/phase-banner/_index.scss b/packages/govuk-frontend/dist/govuk/components/phase-banner/_index.scss
index ca98c3a6c..144e01ab6 100644
--- a/packages/govuk-frontend/dist/govuk/components/phase-banner/_index.scss
+++ b/packages/govuk-frontend/dist/govuk/components/phase-banner/_index.scss
@@ -25,14 +25,6 @@
margin-right: govuk-spacing(2);
}
}
-
- // When forced colour mode is active, for example to provide high contrast,
- // the background colour of the tag is the same as the rest of the page. To ensure
- // that the tag is perceived as separate to the rest of the text in the phase banner,
- // it is made bold.
- @media screen and (forced-colors: active) {
- font-weight: bold;
- }
}
.govuk-phase-banner__text {
Action run for 3d84c82 |
romaricpascal
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot! 🦅
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The phase banner uses the tag component, which takes care of doing this for us since 976535e (part of #3502):
govuk-frontend/packages/govuk-frontend/src/govuk/components/tag/_index.scss
Lines 32 to 40 in 3822ac1