Add tests for fieldset component #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-509
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-509
NickColley
changed the title
|
I need to test the 'caller' method of nesting Edit: I've got some working code but it's pretty beefy so will raise an issue and solve this separately. |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-509
NickColley
force-pushed
the
add-tests-for-fieldset-component
branch
from
ba5740b
to
e743d33
Compare
NickColley
changed the title
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-509
Removes unneeded example from review application that is now tested by a unit test. Updates examples to be a little more realisitic. Ensures that the fieldset and legend elements are used.
NickColley
force-pushed
the
add-tests-for-fieldset-component
branch
from
e743d33
to
562d33b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unneeded example from review application that is now tested by a unit test.
Updates examples to be a little more realisitic.
Ensures that the fieldset and legend elements are used.
As part of https://trello.com/c/L41kC1Rj/654-automated-tests-for-fieldset-component