Add phase-banner component tests #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-505
36degrees
reviewed
Feb 6, 2018
| "html": "<i>alpha</i>" | ||
| }, | ||
| "html": "This is a new service – your <a href=\"#\" class=\"govuk-link\">feedback</a> will help us to improve it." | ||
| "text": "This is a new service – your <a href=\"#\" class=\"govuk-link\">feedback</a> will help us to improve it." |
There was a problem hiding this comment.
This doesn't match the example in the yaml file and the text is escaped - does it need updating?
kr8n3r
force-pushed
the
phase-banner-tests
branch
from
4ba4819
to
e9b9016
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-505
kr8n3r
force-pushed
the
phase-banner-tests
branch
from
e9b9016
to
cf10f00
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-505
|
yeah, fixed |
kr8n3r
force-pushed
the
phase-banner-tests
branch
from
cf10f00
to
b4c989b
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-505
kr8n3r
changed the title
kr8n3r
force-pushed
the
phase-banner-tests
branch
from
b4c989b
to
f7381be
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Trello card: https://trello.com/c/f44OMSDX/662-automated-tests-for-phase-banner-component