Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for file upload macro #504

Merged
merged 2 commits into from
Feb 6, 2018
Merged

Add tests for file upload macro #504

merged 2 commits into from
Feb 6, 2018

Conversation

alex-ju
Copy link
Contributor

@alex-ju alex-ju commented Feb 6, 2018

This PR:

  • Adds tests to file upload component to ensure the markup is rendered correctly when providing arguments to the macro;
  • Updates CHANGELOG.MD.

Trello Card

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-504 February 6, 2018 08:56 Inactive
@alex-ju alex-ju force-pushed the add-tests-for-file-upload-macro branch from 0ce12df to 2259278 Compare February 6, 2018 08:57
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-504 February 6, 2018 08:57 Inactive
36degrees
36degrees reviewed Feb 6, 2018
View reviewed changes
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry is incorrect, but otherwise looks good to me.

CHANGELOG.md Outdated
@@ -49,6 +49,7 @@ Internal:
- Add tests for textarea component (PR [#497](https://github.com/alphagov/govuk-frontend/pull/497))
- Add tests for panel component (PR [#500](https://github.com/alphagov/govuk-frontend/pull/500))
- Add tests for skip-link component (PR [#498](https://github.com/alphagov/govuk-frontend/pull/498))
- Add tests for date-input component (PR [#504](https://github.com/alphagov/govuk-frontend/pull/504))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lame.. Updated.

@alex-ju alex-ju force-pushed the add-tests-for-file-upload-macro branch from 2259278 to 022a527 Compare February 6, 2018 09:27
36degrees
36degrees approved these changes Feb 6, 2018
View reviewed changes
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alex-ju alex-ju merged commit f3783f4 into master Feb 6, 2018
@alex-ju alex-ju deleted the add-tests-for-file-upload-macro branch February 6, 2018 09:32
@alex-ju alex-ju mentioned this pull request Feb 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@36degrees 36degrees 36degrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-ju @36degrees @govuk-design-system-ci