Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Panel component tests #500

Merged
merged 4 commits into from
Feb 5, 2018
Merged

Add Panel component tests #500

merged 4 commits into from
Feb 5, 2018

Conversation

kr8n3r
Copy link

@kr8n3r kr8n3r commented Feb 5, 2018 •
edited
Loading

This PR:

  • Adds tests to textarea component to ensure the markup is rendered correctly when providing arguments to the macro
  • Removes redundant variant and updates text in the default example
  • Updates CHANGELOG.MD.

Trello ticket: https://trello.com/c/OY36WaZo/663-automated-tests-for-panel-component

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-500 February 5, 2018 16:21 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-500 February 5, 2018 16:22 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-500 February 5, 2018 16:33 Inactive
36degrees
36degrees approved these changes Feb 5, 2018
View reviewed changes
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👌

@kr8n3r
Copy link
Author

kr8n3r commented Feb 5, 2018

need to rebase :(

@kr8n3r kr8n3r merged commit d20aec4 into master Feb 5, 2018
@kr8n3r kr8n3r deleted the panel-component-tests branch February 5, 2018 16:49
@alex-ju alex-ju mentioned this pull request Feb 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@36degrees 36degrees 36degrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kr8n3r @36degrees @govuk-design-system-ci