Add tests for skip link #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution to GOV.UK Frontend :) The tests have failed because external contributors cannot run Tenon as it uses secrets, I'll get this to run for you. Edit: Looks like you have a linting error, can you fix that up and push again? |
Closed
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-499
|
Screenshot of focused 'split-link' component |
|
👍 well done! you'll have to rebase/fix conflicts, unfortunately, because another PR has been merged before and the |
|
Thanks Peter! 💯 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with Nick Colley to write tests for 'skip link' component, https://trello.com/c/7vIsgfGw/653-automated-tests-for-skip-link-component