Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove README content from review app #482

Merged
merged 5 commits into from
Feb 15, 2018
Merged

Remove README content from review app #482

merged 5 commits into from
Feb 15, 2018

Commits on Feb 15, 2018

  1. Remove README content from review app 

    Remove the component description, guidance and table of arguments from
the component view within the review app. This will leave just the
component title and the examples.
    Jani Kraner committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    ad163e1 View commit details
    Browse the repository at this point in the history

  2. Add new template for README generation 

    We've decided to extend the README generation from a separate template
instead of having multiple 'if/else' or 'if not' statements in one
template.
    Jani Kraner committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    802b23e View commit details
    Browse the repository at this point in the history

  3. Add logic to determine template extend 

    Inside generate:readme task we add a global 'isReadme: true' to the
nunjucks environment that we use to determine which content should go
where.

We've use this to now to extend the correct template in each of the
components 'index.njk' files.
    Jani Kraner committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    c3c0330 View commit details
    Browse the repository at this point in the history

  4. Update all component READMEs

    Jani Kraner committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    6882ec2 View commit details
    Browse the repository at this point in the history

  5. Document change in changelog

    Jani Kraner committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    30fb1f8 View commit details
    Browse the repository at this point in the history