Remove redundant border div from details component #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This div was included when the original component was created in 2e6769a but as far as I can tell has never actually done anything. There are no other mentions of the string “govuk-c-border” within the src directory. Verified by inspecting the element in Chrome to ensure that the element did not have any styling applied and by manually comparing the component before and after removal. I also ran `git log -p -S "govuk-c-border" -- . ':(exclude)*README.md' ':(exclude)dist' ':(exclude)packages’` and grepped the output for mentions of govuk-c-border in stylesheets.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-481
NickColley
approved these changes
Jan 29, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This div was included when the original component was created in 2e6769a but as far as I can tell has never actually done anything. There are no other mentions of the string “govuk-c-border” within the src directory.
Verified by inspecting the element in Chrome to ensure that the element did not have any styling applied and by manually comparing the component before and after removal.
I also ran
git log -p -S "govuk-c-border" -- . ':(exclude)*README.md' ':(exclude)dist' ':(exclude)packages’and grepped the output for mentions of govuk-c-border in stylesheets.https://trello.com/c/ULH6d6Zr/676-remove-redundant-govuk-c-border-div-from-details-component