Add tests for the details component #480
Conversation
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-480
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-480
| const { $ } = render('details', examples.default) | ||
|
|
||
| // Look for the summary element within the details element | ||
| const $summary = $('.govuk-c-details__summary', '.govuk-c-details') |
There was a problem hiding this comment.
Didn't even know you could do this, I've been doing $('...').find('...') all this time.
There was a problem hiding this comment.
Yeah, I think it's called 'context' in jQuery-land. I've seen in the past people generally aren't that aware of it – hence the comment. Do you think it's clear enough what's it doing?
There was a problem hiding this comment.
In this specific case I'd just rely on good ol' CSS selectors $('.govuk-c-details .govuk-c-details__summary') which would hopefully be more widely understood.
Either way the comment is good, so not blocking.
There was a problem hiding this comment.
That's a good call, though not sure we'd want to use > as that would be testing that the summary is a direct descendant - which I don't think we care about?
There was a problem hiding this comment.
I stealth removed the direct descendant, but wasn't quick enough 😢
36degrees
force-pushed
the
add-details-component-tests
branch
from
ade51b9
to
55d83fa
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-480
36degrees
force-pushed
the
add-details-component-tests
branch
from
55d83fa
to
0a91bc0
Compare
https://trello.com/c/lJzDNEvk/642-automated-tests-for-details-component