Add tests for govuk-c-warning-text component
#479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-479
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-479
hannalaakso
changed the title
govuk-c-warning-text component
hannalaakso
changed the title
govuk-c-warning-text componentgovuk-c-warning-text component
36degrees
reviewed
Jan 29, 2018
| expect($assistiveText.text()).toEqual('Warning') | ||
| }) | ||
|
|
||
| it('renders the default example with aria attribute for icon', () => { |
There was a problem hiding this comment.
We could be clearer with our intent here. How about something like…
It hides the icon from screen readers using the aria-hidden attribute
?
There was a problem hiding this comment.
A very good call 💯 Have amended.
| expect($component.hasClass('govuk-c-warning-text--custom-class')).toBeTruthy() | ||
| }) | ||
|
|
||
| it('renders custom text and custom assistive text', () => { |
There was a problem hiding this comment.
I think this would make more sense as two different tests.
There was a problem hiding this comment.
I was in two minds about that but I think you're right. Have split it into two tests.
| 'data-test': 'attribute', | ||
| 'id': 'my-warning-text' | ||
| }, | ||
| html: '<span>Some custom warning text</span>' |
There was a problem hiding this comment.
This isn't being tested here. Can it just be omitted?
hannalaakso
force-pushed
the
tests-warning-text
branch
from
fccf2fd to
fb0d6f5
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-479
hannalaakso
force-pushed
the
tests-warning-text
branch
from
fb0d6f5 to
2fa7815
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-479
They test if the component: - renders the default example with text and assistive text - renders the default example with aria attribute for icon - renders classes - renders custom text and custom assistive text - renders escaped html when passed to text - renders html - renders attributes
hannalaakso
force-pushed
the
tests-warning-text
branch
from
2fa7815 to
e90a6af
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Jest tests for the warning text component.
They test if the component: