-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Nunjucks HTML indentation: Select #4712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4712
February 1, 2024 12:16
Inactive
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for c5a22ad |
Rendered HTML changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/components/select/template-default.html b/packages/govuk-frontend/dist/govuk/components/select/template-default.html
index b84997c16..4d093050b 100644
--- a/packages/govuk-frontend/dist/govuk/components/select/template-default.html
+++ b/packages/govuk-frontend/dist/govuk/components/select/template-default.html
@@ -3,11 +3,8 @@
Label text goes here
</label>
<select class="govuk-select" id="select-1" name="select-1">
-
- <option value="1">GOV.UK frontend option 1</option>
-
- <option value="2" selected>GOV.UK frontend option 2</option>
-
- <option value="3" disabled>GOV.UK frontend option 3</option>
+ <option value="1">GOV.UK frontend option 1</option>
+ <option value="2" selected>GOV.UK frontend option 2</option>
+ <option value="3" disabled>GOV.UK frontend option 3</option>
</select>
</div>
diff --git a/packages/govuk-frontend/dist/govuk/components/select/template-with-full-width-override.html b/packages/govuk-frontend/dist/govuk/components/select/template-with-full-width-override.html
index 952156a65..99c41b088 100644
--- a/packages/govuk-frontend/dist/govuk/components/select/template-with-full-width-override.html
+++ b/packages/govuk-frontend/dist/govuk/components/select/template-with-full-width-override.html
@@ -3,11 +3,8 @@
Label text goes here
</label>
<select class="govuk-select govuk-!-width-full" id="select-1" name="select-1">
-
- <option value="1">GOV.UK frontend option 1</option>
-
- <option value="2" selected>GOV.UK frontend option 2</option>
-
- <option value="3" disabled>GOV.UK frontend option 3</option>
+ <option value="1">GOV.UK frontend option 1</option>
+ <option value="2" selected>GOV.UK frontend option 2</option>
+ <option value="3" disabled>GOV.UK frontend option 3</option>
</select>
</div>
diff --git a/packages/govuk-frontend/dist/govuk/components/select/template-with-hint-text-and-error-message.html b/packages/govuk-frontend/dist/govuk/components/select/template-with-hint-text-and-error-message.html
index 7f634e9cd..41ddf5c54 100644
--- a/packages/govuk-frontend/dist/govuk/components/select/template-with-hint-text-and-error-message.html
+++ b/packages/govuk-frontend/dist/govuk/components/select/template-with-hint-text-and-error-message.html
@@ -9,11 +9,8 @@
<span class="govuk-visually-hidden">Error:</span> Error message goes here
</p>
<select class="govuk-select govuk-select--error" id="select-2" name="select-2" aria-describedby="select-2-hint select-2-error">
-
- <option value="1">GOV.UK frontend option 1</option>
-
- <option value="2">GOV.UK frontend option 2</option>
-
- <option value="3">GOV.UK frontend option 3</option>
+ <option value="1">GOV.UK frontend option 1</option>
+ <option value="2">GOV.UK frontend option 2</option>
+ <option value="3">GOV.UK frontend option 3</option>
</select>
</div>
diff --git a/packages/govuk-frontend/dist/govuk/components/select/template-with-label-as-page-heading.html b/packages/govuk-frontend/dist/govuk/components/select/template-with-label-as-page-heading.html
index 916bf7bab..9f3e543bf 100644
--- a/packages/govuk-frontend/dist/govuk/components/select/template-with-label-as-page-heading.html
+++ b/packages/govuk-frontend/dist/govuk/components/select/template-with-label-as-page-heading.html
@@ -5,11 +5,8 @@
</label>
</h1>
<select class="govuk-select" id="select-3" name="select-3">
-
- <option value="1">GOV.UK frontend option 1</option>
-
- <option value="2" selected>GOV.UK frontend option 2</option>
-
- <option value="3" disabled>GOV.UK frontend option 3</option>
+ <option value="1">GOV.UK frontend option 1</option>
+ <option value="2" selected>GOV.UK frontend option 2</option>
+ <option value="3" disabled>GOV.UK frontend option 3</option>
</select>
</div>
diff --git a/packages/govuk-frontend/dist/govuk/components/select/template-with-optional-form-group-classes.html b/packages/govuk-frontend/dist/govuk/components/select/template-with-optional-form-group-classes.html
index b51148774..2ab39b640 100644
--- a/packages/govuk-frontend/dist/govuk/components/select/template-with-optional-form-group-classes.html
+++ b/packages/govuk-frontend/dist/govuk/components/select/template-with-optional-form-group-classes.html
@@ -3,11 +3,8 @@
Label text goes here
</label>
<select class="govuk-select govuk-!-width-full" id="select-1" name="select-1">
-
- <option value="1">GOV.UK frontend option 1</option>
-
- <option value="2" selected>GOV.UK frontend option 2</option>
-
- <option value="3" disabled>GOV.UK frontend option 3</option>
+ <option value="1">GOV.UK frontend option 1</option>
+ <option value="2" selected>GOV.UK frontend option 2</option>
+ <option value="3" disabled>GOV.UK frontend option 3</option>
</select>
</div>
diff --git a/packages/govuk-frontend/dist/govuk/components/select/template-with-selected-value.html b/packages/govuk-frontend/dist/govuk/components/select/template-with-selected-value.html
index b84997c16..4d093050b 100644
--- a/packages/govuk-frontend/dist/govuk/components/select/template-with-selected-value.html
+++ b/packages/govuk-frontend/dist/govuk/components/select/template-with-selected-value.html
@@ -3,11 +3,8 @@
Label text goes here
</label>
<select class="govuk-select" id="select-1" name="select-1">
-
- <option value="1">GOV.UK frontend option 1</option>
-
- <option value="2" selected>GOV.UK frontend option 2</option>
-
- <option value="3" disabled>GOV.UK frontend option 3</option>
+ <option value="1">GOV.UK frontend option 1</option>
+ <option value="2" selected>GOV.UK frontend option 2</option>
+ <option value="3" disabled>GOV.UK frontend option 3</option>
</select>
</div>
Action run for c5a22ad |
Other changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/components/select/fixtures.json b/packages/govuk-frontend/dist/govuk/components/select/fixtures.json
index c58f9f04d..9f9c66e22 100644
--- a/packages/govuk-frontend/dist/govuk/components/select/fixtures.json
+++ b/packages/govuk-frontend/dist/govuk/components/select/fixtures.json
@@ -29,7 +29,7 @@
"hidden": false,
"description": "",
"previewLayoutModifiers": [],
- "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"select-1\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"select-1\" name=\"select-1\">\n \n <option value=\"1\">GOV.UK frontend option 1</option>\n \n <option value=\"2\" selected>GOV.UK frontend option 2</option>\n \n <option value=\"3\" disabled>GOV.UK frontend option 3</option>\n </select>\n</div>"
+ "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"select-1\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"select-1\" name=\"select-1\">\n <option value=\"1\">GOV.UK frontend option 1</option>\n <option value=\"2\" selected>GOV.UK frontend option 2</option>\n <option value=\"3\" disabled>GOV.UK frontend option 3</option>\n </select>\n</div>"
},
{
"name": "with no items",
@@ -74,7 +74,7 @@
"hidden": false,
"description": "",
"previewLayoutModifiers": [],
- "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"select-1\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"select-1\" name=\"select-1\">\n \n <option value=\"1\">GOV.UK frontend option 1</option>\n \n <option value=\"2\" selected>GOV.UK frontend option 2</option>\n \n <option value=\"3\" disabled>GOV.UK frontend option 3</option>\n </select>\n</div>"
+ "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"select-1\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"select-1\" name=\"select-1\">\n <option value=\"1\">GOV.UK frontend option 1</option>\n <option value=\"2\" selected>GOV.UK frontend option 2</option>\n <option value=\"3\" disabled>GOV.UK frontend option 3</option>\n </select>\n</div>"
},
{
"name": "with hint text and error message",
@@ -108,7 +108,7 @@
"hidden": false,
"description": "",
"previewLayoutModifiers": [],
- "html": "<div class=\"govuk-form-group govuk-form-group--error\">\n <label class=\"govuk-label\" for=\"select-2\">\n Label text goes here\n </label>\n <div id=\"select-2-hint\" class=\"govuk-hint\">\n Hint text goes here\n </div>\n <p id=\"select-2-error\" class=\"govuk-error-message\">\n <span class=\"govuk-visually-hidden\">Error:</span> Error message goes here\n </p>\n <select class=\"govuk-select govuk-select--error\" id=\"select-2\" name=\"select-2\" aria-describedby=\"select-2-hint select-2-error\">\n \n <option value=\"1\">GOV.UK frontend option 1</option>\n \n <option value=\"2\">GOV.UK frontend option 2</option>\n \n <option value=\"3\">GOV.UK frontend option 3</option>\n </select>\n</div>"
+ "html": "<div class=\"govuk-form-group govuk-form-group--error\">\n <label class=\"govuk-label\" for=\"select-2\">\n Label text goes here\n </label>\n <div id=\"select-2-hint\" class=\"govuk-hint\">\n Hint text goes here\n </div>\n <p id=\"select-2-error\" class=\"govuk-error-message\">\n <span class=\"govuk-visually-hidden\">Error:</span> Error message goes here\n </p>\n <select class=\"govuk-select govuk-select--error\" id=\"select-2\" name=\"select-2\" aria-describedby=\"select-2-hint select-2-error\">\n <option value=\"1\">GOV.UK frontend option 1</option>\n <option value=\"2\">GOV.UK frontend option 2</option>\n <option value=\"3\">GOV.UK frontend option 3</option>\n </select>\n</div>"
},
{
"name": "with label as page heading",
@@ -140,7 +140,7 @@
"hidden": false,
"description": "",
"previewLayoutModifiers": [],
- "html": "<div class=\"govuk-form-group\">\n <h1 class=\"govuk-label-wrapper\">\n <label class=\"govuk-label govuk-label--l\" for=\"select-3\">\n Label text goes here\n </label>\n </h1>\n <select class=\"govuk-select\" id=\"select-3\" name=\"select-3\">\n \n <option value=\"1\">GOV.UK frontend option 1</option>\n \n <option value=\"2\" selected>GOV.UK frontend option 2</option>\n \n <option value=\"3\" disabled>GOV.UK frontend option 3</option>\n </select>\n</div>"
+ "html": "<div class=\"govuk-form-group\">\n <h1 class=\"govuk-label-wrapper\">\n <label class=\"govuk-label govuk-label--l\" for=\"select-3\">\n Label text goes here\n </label>\n </h1>\n <select class=\"govuk-select\" id=\"select-3\" name=\"select-3\">\n <option value=\"1\">GOV.UK frontend option 1</option>\n <option value=\"2\" selected>GOV.UK frontend option 2</option>\n <option value=\"3\" disabled>GOV.UK frontend option 3</option>\n </select>\n</div>"
},
{
"name": "with full width override",
@@ -171,7 +171,7 @@
"hidden": false,
"description": "",
"previewLayoutModifiers": [],
- "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"select-1\">\n Label text goes here\n </label>\n <select class=\"govuk-select govuk-!-width-full\" id=\"select-1\" name=\"select-1\">\n \n <option value=\"1\">GOV.UK frontend option 1</option>\n \n <option value=\"2\" selected>GOV.UK frontend option 2</option>\n \n <option value=\"3\" disabled>GOV.UK frontend option 3</option>\n </select>\n</div>"
+ "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"select-1\">\n Label text goes here\n </label>\n <select class=\"govuk-select govuk-!-width-full\" id=\"select-1\" name=\"select-1\">\n <option value=\"1\">GOV.UK frontend option 1</option>\n <option value=\"2\" selected>GOV.UK frontend option 2</option>\n <option value=\"3\" disabled>GOV.UK frontend option 3</option>\n </select>\n</div>"
},
{
"name": "with optional form-group classes",
@@ -205,7 +205,7 @@
"hidden": false,
"description": "",
"previewLayoutModifiers": [],
- "html": "<div class=\"govuk-form-group extra-class\">\n <label class=\"govuk-label\" for=\"select-1\">\n Label text goes here\n </label>\n <select class=\"govuk-select govuk-!-width-full\" id=\"select-1\" name=\"select-1\">\n \n <option value=\"1\">GOV.UK frontend option 1</option>\n \n <option value=\"2\" selected>GOV.UK frontend option 2</option>\n \n <option value=\"3\" disabled>GOV.UK frontend option 3</option>\n </select>\n</div>"
+ "html": "<div class=\"govuk-form-group extra-class\">\n <label class=\"govuk-label\" for=\"select-1\">\n Label text goes here\n </label>\n <select class=\"govuk-select govuk-!-width-full\" id=\"select-1\" name=\"select-1\">\n <option value=\"1\">GOV.UK frontend option 1</option>\n <option value=\"2\" selected>GOV.UK frontend option 2</option>\n <option value=\"3\" disabled>GOV.UK frontend option 3</option>\n </select>\n</div>"
},
{
"name": "with describedBy",
@@ -230,7 +230,7 @@
"hidden": true,
"description": "",
"previewLayoutModifiers": [],
- "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"with-describedby\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"with-describedby\" name=\"with-describedby\" aria-describedby=\"test-target-element\">\n \n <option value=\"1\">GOV.UK frontend option 1</option>\n \n <option value=\"2\">GOV.UK frontend option 2</option>\n </select>\n</div>"
+ "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"with-describedby\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"with-describedby\" name=\"with-describedby\" aria-describedby=\"test-target-element\">\n <option value=\"1\">GOV.UK frontend option 1</option>\n <option value=\"2\">GOV.UK frontend option 2</option>\n </select>\n</div>"
},
{
"name": "attributes",
@@ -257,7 +257,7 @@
"hidden": true,
"description": "",
"previewLayoutModifiers": [],
- "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"with-attributes\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"with-attributes\" name=\"with-attributes\" data-attribute=\"my data value\">\n \n <option value=\"1\">GOV.UK frontend option 1</option>\n \n <option value=\"2\">GOV.UK frontend option 2</option>\n </select>\n</div>"
+ "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"with-attributes\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"with-attributes\" name=\"with-attributes\" data-attribute=\"my data value\">\n <option value=\"1\">GOV.UK frontend option 1</option>\n <option value=\"2\">GOV.UK frontend option 2</option>\n </select>\n</div>"
},
{
"name": "attributes on items",
@@ -290,7 +290,7 @@
"hidden": true,
"description": "",
"previewLayoutModifiers": [],
- "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"with-item-attributes\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"with-item-attributes\" name=\"with-item-attributes\">\n \n <option value=\"1\" data-attribute=\"ABC\" data-second-attribute=\"DEF\">Option 1</option>\n \n <option value=\"2\" selected data-attribute=\"GHI\" data-second-attribute=\"JKL\">Option 2</option>\n </select>\n</div>"
+ "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"with-item-attributes\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"with-item-attributes\" name=\"with-item-attributes\">\n <option value=\"1\" data-attribute=\"ABC\" data-second-attribute=\"DEF\">Option 1</option>\n <option value=\"2\" selected data-attribute=\"GHI\" data-second-attribute=\"JKL\">Option 2</option>\n </select>\n</div>"
},
{
"name": "with falsey items",
@@ -317,7 +317,7 @@
"hidden": true,
"description": "",
"previewLayoutModifiers": [],
- "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"with-falsey-items\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"with-falsey-items\" name=\"with-falsey-items\">\n \n <option value=\"1\">Option 1</option>\n \n <option value=\"2\">Options 2</option>\n </select>\n</div>"
+ "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"with-falsey-items\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"with-falsey-items\" name=\"with-falsey-items\">\n <option value=\"1\">Option 1</option>\n <option value=\"2\">Options 2</option>\n </select>\n</div>"
},
{
"name": "hint",
@@ -362,7 +362,7 @@
"hidden": true,
"description": "",
"previewLayoutModifiers": [],
- "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"select-with-hint\">\n Label text goes here\n </label>\n <div id=\"select-with-hint-hint\" class=\"govuk-hint\">\n Hint text goes here\n </div>\n <select class=\"govuk-select\" id=\"select-with-hint\" name=\"select-with-hint\" aria-describedby=\"test-target-element select-with-hint-hint\">\n \n <option value=\"1\">GOV.UK frontend option 1</option>\n \n <option value=\"2\">GOV.UK frontend option 2</option>\n </select>\n</div>"
+ "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"select-with-hint\">\n Label text goes here\n </label>\n <div id=\"select-with-hint-hint\" class=\"govuk-hint\">\n Hint text goes here\n </div>\n <select class=\"govuk-select\" id=\"select-with-hint\" name=\"select-with-hint\" aria-describedby=\"test-target-element select-with-hint-hint\">\n <option value=\"1\">GOV.UK frontend option 1</option>\n <option value=\"2\">GOV.UK frontend option 2</option>\n </select>\n</div>"
},
{
"name": "error",
@@ -389,7 +389,7 @@
"hidden": true,
"description": "",
"previewLayoutModifiers": [],
- "html": "<div class=\"govuk-form-group govuk-form-group--error\">\n <label class=\"govuk-label\" for=\"select-with-error\">\n Label text goes here\n </label>\n <p id=\"select-with-error-error\" class=\"govuk-error-message\">\n <span class=\"govuk-visually-hidden\">Error:</span> Error message\n </p>\n <select class=\"govuk-select govuk-select--error\" id=\"select-with-error\" name=\"select-with-error\" aria-describedby=\"select-with-error-error\">\n \n <option value=\"1\">GOV.UK frontend option 1</option>\n \n <option value=\"2\">GOV.UK frontend option 2</option>\n </select>\n</div>"
+ "html": "<div class=\"govuk-form-group govuk-form-group--error\">\n <label class=\"govuk-label\" for=\"select-with-error\">\n Label text goes here\n </label>\n <p id=\"select-with-error-error\" class=\"govuk-error-message\">\n <span class=\"govuk-visually-hidden\">Error:</span> Error message\n </p>\n <select class=\"govuk-select govuk-select--error\" id=\"select-with-error\" name=\"select-with-error\" aria-describedby=\"select-with-error-error\">\n <option value=\"1\">GOV.UK frontend option 1</option>\n <option value=\"2\">GOV.UK frontend option 2</option>\n </select>\n</div>"
},
{
"name": "error and describedBy",
@@ -417,7 +417,7 @@
"hidden": true,
"description": "",
"previewLayoutModifiers": [],
- "html": "<div class=\"govuk-form-group govuk-form-group--error\">\n <label class=\"govuk-label\" for=\"select-with-error\">\n Label text goes here\n </label>\n <p id=\"select-with-error-error\" class=\"govuk-error-message\">\n <span class=\"govuk-visually-hidden\">Error:</span> Error message\n </p>\n <select class=\"govuk-select govuk-select--error\" id=\"select-with-error\" name=\"select-with-error\" aria-describedby=\"test-target-element select-with-error-error\">\n \n <option value=\"1\">GOV.UK frontend option 1</option>\n \n <option value=\"2\">GOV.UK frontend option 2</option>\n </select>\n</div>"
+ "html": "<div class=\"govuk-form-group govuk-form-group--error\">\n <label class=\"govuk-label\" for=\"select-with-error\">\n Label text goes here\n </label>\n <p id=\"select-with-error-error\" class=\"govuk-error-message\">\n <span class=\"govuk-visually-hidden\">Error:</span> Error message\n </p>\n <select class=\"govuk-select govuk-select--error\" id=\"select-with-error\" name=\"select-with-error\" aria-describedby=\"test-target-element select-with-error-error\">\n <option value=\"1\">GOV.UK frontend option 1</option>\n <option value=\"2\">GOV.UK frontend option 2</option>\n </select>\n</div>"
},
{
"name": "without values",
@@ -442,7 +442,7 @@
"hidden": true,
"description": "",
"previewLayoutModifiers": [],
- "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"colors\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"colors\" name=\"colors\">\n \n <option>Red</option>\n \n <option>Green</option>\n \n <option>Blue</option>\n </select>\n</div>"
+ "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"colors\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"colors\" name=\"colors\">\n <option>Red</option>\n <option>Green</option>\n <option>Blue</option>\n </select>\n</div>"
},
{
"name": "without values with selected value",
@@ -468,7 +468,7 @@
"hidden": true,
"description": "",
"previewLayoutModifiers": [],
- "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"colors\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"colors\" name=\"colors\">\n \n <option>Red</option>\n \n <option selected>Green</option>\n \n <option>Blue</option>\n </select>\n</div>"
+ "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"colors\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"colors\" name=\"colors\">\n <option>Red</option>\n <option selected>Green</option>\n <option>Blue</option>\n </select>\n</div>"
},
{
"name": "with falsey values",
@@ -496,7 +496,7 @@
"hidden": true,
"description": "",
"previewLayoutModifiers": [],
- "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"falsey-values\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"falsey-values\" name=\"falsey-values\">\n \n <option value=\"\">Empty string</option>\n \n <option value=\"false\">Boolean false</option>\n \n <option value=\"0\">Number zero</option>\n </select>\n</div>"
+ "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"falsey-values\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"falsey-values\" name=\"falsey-values\">\n <option value=\"\">Empty string</option>\n <option value=\"false\">Boolean false</option>\n <option value=\"0\">Number zero</option>\n </select>\n</div>"
},
{
"name": "item selected overrides value",
@@ -526,7 +526,7 @@
"hidden": true,
"description": "",
"previewLayoutModifiers": [],
- "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"colors\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"colors\" name=\"colors\">\n \n <option value=\"red\">Red</option>\n \n <option value=\"green\">Green</option>\n \n <option value=\"blue\">Blue</option>\n </select>\n</div>"
+ "html": "<div class=\"govuk-form-group\">\n <label class=\"govuk-label\" for=\"colors\">\n Label text goes here\n </label>\n <select class=\"govuk-select\" id=\"colors\" name=\"colors\">\n <option value=\"red\">Red</option>\n <option value=\"green\">Green</option>\n <option value=\"blue\">Blue</option>\n </select>\n</div>"
}
]
}
Action run for c5a22ad |
36degrees
approved these changes
Feb 6, 2024
owenatgov
pushed a commit
that referenced
this pull request
Apr 4, 2024
Fix Nunjucks HTML indentation: Select
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select changes, split out from #4448 to partially resolve #3211
This PR removes empty new lines and leading spaces before
<option>
elements