Remove font weight from link styles #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link styles should not specify a weight. This fixes the fact that if you include a link within a heading or some other element which you would expect to render as bold, the link will be rendered in regular weight.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-469
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes font weight from link styles.
Because link styles used to include a regular font weight, including a link within a heading which you would expect to render as bold, or using some other element which inherits bold font weight would have its weight set to regular. This fixes that issue.
Once released, we'll be able to remove the styles set in this commit: alphagov/govuk-design-system@e7dc941
https://trello.com/c/1bhIr3Cu/647-link-styles-include-regular-font-weight