Add tests for govuk-c-tag component
#457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-457
|
this looks good from my POV |
36degrees
reviewed
Jan 24, 2018
src/components/tag/template.test.js
Outdated
|
|
||
| it('renders custom text correctly', () => { | ||
| const { $ } = render('tag', { | ||
| text: 'alpha' |
There was a problem hiding this comment.
This is the same text as in the default example, so we could change the logic to hard code alpha and I think all of these tests would still pass? Suggest specifying some text that would not normally appear in any of our examples.
hannalaakso
force-pushed
the
component-tests
branch
from
cda2ad9
to
accf1fc
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-457
These test if the component: - renders the default example with strong tag and text correctly - renders classes correctly - renders custom text correctly - renders escaped html when passed to text - renders html correctly - renders attributes correctly
This follows our decision that examples from the component definition that are now redundant and no longer useful in the review app are removed
hannalaakso
force-pushed
the
component-tests
branch
from
accf1fc
to
741e3e4
Compare
|
This is ready to review. I made the description of the tests resemble more closely the sort of natural language that we agreed on with the team. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Jest tests for
govuk-c-tagcomponent.These test if the component:
Remove tag
--with-htmlexample from FE review app. This follows our decision that examples from the component definition that are now redundant and no longer useful in the review app are removed.Trello card: https://trello.com/c/2Mv7onR8/637-automated-tests-for-tag-component