-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PR diff comments in order #4523
Conversation
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for ed74d5c |
JavaScript changes to npm packageNo changes found. Action run for ed74d5c |
Stylesheets changes to npm packageNo changes found. Action run for ed74d5c |
Other changes to npm packageNo changes found. Action run for ed74d5c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! Thanks for splitting 😊 ⛵
Whoops, little linting issue before we can merge it seems. Strange that Husky didn't pick it up, but maybe it's because the commits were moved with rebases 🤔 |
We always want JavaScript and Stylesheets first
5a54afd
to
ed74d5c
Compare
Yeah all sorted, the The ones in this PR were cherry picked so Husky doesn't kick in |
@romaricpascal See what Brett means about the 4x comments on every PR, like this one? |
This PR addresses one of the review comments in #4511 (review)
Posting GitHub diff comments in order
We previously used
Promise.allSettled()
but the least useful "Other changes" comment often comes firstThis PR now adds comments in the order they're configured