-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove X-UA-Compatible meta tag #4434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4434
November 6, 2023 14:06
Inactive
colinrotherham
approved these changes
Nov 6, 2023
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for fbe4fab |
36degrees
reviewed
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this probably needs a changelog entry.
This meta tag ensured that older versions of Internet Explorer (IE8 onwards) used the most recent renderer and rendering rules available to them. IE11 does not require this meta tag. It deprecates the X-UA-Compatible meta tag and now uses the most recent renderer automatically if the doctype is `<!DOCTYPE html>`. Both the EdgeHTML and Chromium versions of Edge ignore the meta tag entirely. https://learn.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/dev-guides/bg182625(v=vs.85)#document-mode-changes
querkmachine
force-pushed
the
remove-ua-compatible-meta-tag
branch
from
November 6, 2023 14:56
30fcc35
to
fbe4fab
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4434
November 6, 2023 14:56
Inactive
@36degrees Added a changelog 👍 |
36degrees
approved these changes
Nov 6, 2023
Merged
owenatgov
pushed a commit
that referenced
this pull request
Jan 11, 2024
Remove X-UA-Compatible meta tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This meta tag ensured that older versions of Internet Explorer (specifically IE8 to IE10) used the most recent renderer and rendering rules available to them, rather than relying on the browser's in-built heuristics that could silently 'downgrade' the renderer. For example: if IE10 thought you were viewing a Sharepoint intranet site, it might automatically switch itself to use IE9's rendering rules.
IE11 does not require this meta tag. It deprecates the X-UA-Compatible meta tag and now uses the most recent renderer automatically if the HTML5 doctype (
<!DOCTYPE html>
) is being used.Both the EdgeHTML and Chromium versions of Edge ignore the meta tag entirely. No non-Microsoft browsers ever supported it, as far as I can find.
As Frontend now only supports Internet Explorer 11, I think we can safely remove this meta tag.
Info from Microsoft regarding the deprecation in IE11: https://learn.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/dev-guides/bg182625(v=vs.85)#document-mode-changes