Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove X-UA-Compatible meta tag #4434

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

querkmachine
Copy link
Member

This meta tag ensured that older versions of Internet Explorer (specifically IE8 to IE10) used the most recent renderer and rendering rules available to them, rather than relying on the browser's in-built heuristics that could silently 'downgrade' the renderer. For example: if IE10 thought you were viewing a Sharepoint intranet site, it might automatically switch itself to use IE9's rendering rules.

IE11 does not require this meta tag. It deprecates the X-UA-Compatible meta tag and now uses the most recent renderer automatically if the HTML5 doctype (<!DOCTYPE html>) is being used.

Both the EdgeHTML and Chromium versions of Edge ignore the meta tag entirely. No non-Microsoft browsers ever supported it, as far as I can find.

As Frontend now only supports Internet Explorer 11, I think we can safely remove this meta tag.

Info from Microsoft regarding the deprecation in IE11: https://learn.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/dev-guides/bg182625(v=vs.85)#document-mode-changes

@querkmachine querkmachine requested a review from a team November 6, 2023 14:06
@querkmachine querkmachine self-assigned this Nov 6, 2023
Copy link

github-actions bot commented Nov 6, 2023

📋 Stats

File sizes

File Size
dist/govuk-frontend-5.0.0-beta.1.min.css 114 KiB
dist/govuk-frontend-5.0.0-beta.1.min.js 37.93 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 77.08 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 72.37 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.8 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 113.53 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 37.92 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.3 KiB

Modules

File Size
all.mjs 68.7 KiB
components/accordion/accordion.mjs 21.35 KiB
components/button/button.mjs 4.48 KiB
components/character-count/character-count.mjs 20.79 KiB
components/checkboxes/checkboxes.mjs 5.61 KiB
components/error-summary/error-summary.mjs 5.79 KiB
components/exit-this-page/exit-this-page.mjs 15.79 KiB
components/header/header.mjs 3.68 KiB
components/notification-banner/notification-banner.mjs 4.32 KiB
components/radios/radios.mjs 4.6 KiB
components/skip-link/skip-link.mjs 3.6 KiB
components/tabs/tabs.mjs 9.37 KiB

View stats and visualisations on the review app


Action run for fbe4fab

Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this probably needs a changelog entry.

This meta tag ensured that older versions of Internet Explorer (IE8 onwards) used the most recent renderer and rendering rules available to
them.

IE11 does not require this meta tag. It deprecates the X-UA-Compatible meta tag and now uses the most
recent renderer automatically if the doctype is `<!DOCTYPE html>`.

Both the EdgeHTML and Chromium versions of Edge ignore the meta tag entirely.

https://learn.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/dev-guides/bg182625(v=vs.85)#document-mode-changes
@querkmachine querkmachine force-pushed the remove-ua-compatible-meta-tag branch from 30fcc35 to fbe4fab Compare November 6, 2023 14:56
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4434 November 6, 2023 14:56 Inactive
@querkmachine
Copy link
Member Author

@36degrees Added a changelog 👍

@querkmachine querkmachine merged commit daafa4b into main Nov 6, 2023
43 checks passed
@querkmachine querkmachine deleted the remove-ua-compatible-meta-tag branch November 6, 2023 17:52
@romaricpascal romaricpascal mentioned this pull request Dec 8, 2023
owenatgov pushed a commit that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants