-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "legal text" to "warning text" #432
Conversation
@@ -26,14 +26,14 @@ | |||
|
|||
min-width: 38px; | |||
min-height: 35px; | |||
margin-top: -19px; // Half the height of the 38px circle | |||
margin-top: -20px; // Half the height of the 38px circle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This comment is confusing now, could update to say 'half the height of the circle'
@dashouse would you mind adding an entry for this to the unreleased section of the changelog? https://github.com/alphagov/govuk-frontend/blob/master/CHANGELOG.md#unreleased Let me know if you want to pair on the versioning side of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me 👍
@igloosi There's no gotcha's hiding with renaming a component I haven't addressed is there? |
4e8b243
to
f8eb9cf
Compare
@dashouse not for this bit, just need to remember to update all.scss file in packages did you rebase from master, where Ollie removed the link component?
|
@dashouse we will need make sure to follow step 11. in https://github.com/alphagov/govuk-frontend/blob/master/docs/publishing.md |
f8eb9cf
to
88206ff
Compare
@NickColley i have removed the link component reference from govuk-frontend.scss file |
👍 when green |
@dashouse I've updated Our new guidance for updating |
@igloosi @NickColley @hannalaakso Sorry I wasn't around for most of this yesterday. Thanks for fixing :) |
In [#432](#432) changes were made directly to README.md that should have been made in index.njk, mainly to update references to the component name, but also to change the 'description' to remove a reference to legal consequences. This updates index.njk to include the change to the description and regenerates the readme with the correct whitespace and capitalisation as well as changes to the arguments table and to the macro example.
https://trello.com/c/45Fnu1yr/254-2-update-legal-text-component-api-and-name