-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Node.js LTS ‘Iron’ (v20) release version #4201
Conversation
dd53b30
to
c8e9afb
Compare
c8e9afb
to
5adec7a
Compare
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 19173ea |
49c229e
to
af093c1
Compare
5adec7a
to
aeb05d0
Compare
af093c1
to
2ad3319
Compare
aeb05d0
to
3a94595
Compare
3a94595
to
7dd8cbc
Compare
7dd8cbc
to
33bb718
Compare
Blocked until Node.js 20 LTS released: 24 October 2023 |
33bb718
to
4e727b6
Compare
4e727b6
to
bb58a4c
Compare
3d816fa
to
4d8c241
Compare
4d8c241
to
e418279
Compare
Heroku builds are still failing, must still be rolling out: -----> Installing binaries
engines.node (package.json): ^20.9.0
engines.npm (package.json): ^10.1.0
Resolving node version ^20.9.0...
Could not find Node version corresponding to version requirement: ^20.9.0
-----> Build failed
! No matching version found for Node: ^20.9.0 We'll keep an eye on the Heroku Changelog |
All sorted, Heroku is ready to go:
|
From our "waiting for" list in #4201 (comment) it looks like we're just missing asdf support: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. nvm
was happy with lts/iron
locally (and Github actions and Heroku) on CI, hopefully asdf won't be long.
Do you know if people will need to update asdf
locally for it to undersand lts/iron
?
@romaricpascal Nah it does an automatic update on Wonder if we should use |
|
e418279
to
0a6a355
Compare
027d3d4
to
19173ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From our discussion on Slack, it seems using 20
in .nvmrc
causes trouble with asdf when Husky runs. That'd make lts/iron
would be fine once asdf
supports it, unless we figure why Husky and asdf don't play nicely.
It'll also be worth coordinating the merge with the rest of the team, so that people know to run nvm
or asdf
to set up the new version.
Thanks @romaricpascal Let's stick with Node.js version managersI've added some notes for typical macOS + ZSH + Homebrew installs For Node.js commit hook support via GUI (e.g. Tower) duplicate these changes into ~/.huskyrc Using
|
The Node.js LTS v20 update in #4201 has stopped Dependabot from running Rather than allow Node.js v18 and npm v9.6.5 we can remove `engine-strict=true` ``` Dependabot uses Node.js v18.18.2 and NPM 9.6.5 . Due to the engine-strict setting, the update will not succeed. ```
The Node.js LTS v20 update in #4201 has stopped Dependabot from running Rather than allow Node.js v18 and npm v9.6.5 we can remove `engine-strict=true` ``` Dependabot uses Node.js v18.18.2 and NPM 9.6.5 . Due to the engine-strict setting, the update will not succeed. ```
Allow Node.js LTS ‘Iron’ (v20) release version
This PR allows Node.js LTS ‘Iron’ (v20) to install, run and build GOV.UK Frontend
Changes included:
Updating .browserslistrc for Node.js 20
So Babel is aware we need to support only
node 20
Updating .nvmrc for Node.js 20
So tools like nvm and asdf allow the
lts/iron
LTS releaseBump the package.json
engines.node
rangeEnsures
npm install
and other scripts check the local Node.js version is allowedBump the package.json
engines.npm
rangeEnsure support for
npm@10
rather thannpm@9