-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw ElementError
when "Exit this page" button is missing
#4199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4199
September 11, 2023 11:50
Inactive
romaricpascal
force-pushed
the
exit-this-page-missing-element
branch
from
September 11, 2023 11:51
86fccbf
to
e532cb5
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4199
September 11, 2023 11:51
Inactive
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 26a179a |
renderAndInitialise(page, 'exit-this-page', { | ||
params: examples.default, | ||
beforeInitialisation($module) { | ||
$module.querySelector('.govuk-exit-this-page__button').remove() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
packages/govuk-frontend/src/govuk/components/exit-this-page/exit-this-page.mjs
Outdated
Show resolved
Hide resolved
romaricpascal
force-pushed
the
exit-this-page-missing-element
branch
from
September 12, 2023 11:28
e532cb5
to
99f97df
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4199
September 12, 2023 11:28
Inactive
romaricpascal
changed the title
Throw
Throw Sep 12, 2023
MissingElementError
when "Exit this page" button is missingElementError
when "Exit this page" button is missing
romaricpascal
force-pushed
the
components-type-error
branch
from
September 15, 2023 07:56
f87a21e
to
ba4cf7f
Compare
colinrotherham
force-pushed
the
components-type-error
branch
2 times, most recently
from
September 18, 2023 13:29
090e1b6
to
655af8f
Compare
romaricpascal
force-pushed
the
exit-this-page-missing-element
branch
from
September 18, 2023 15:00
99f97df
to
26a179a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4199
September 18, 2023 15:01
Inactive
colinrotherham
approved these changes
Sep 18, 2023
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wording to match that of the Skip link component, but to be reviewed in #4072.Wording is now handled by theElementError
class and will match the otherElementError
being thrown.Closes #4129