Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Actions export tests for Node.js v20 #3956

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Add GitHub Actions export tests for Node.js v20 #3956

merged 3 commits into from
Aug 1, 2023

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented Jul 13, 2023 •
edited
Loading

Node.js v20 reaches LTS in October 2023 so good to test early

Also addresses an unnecessary node_modules cache restoration review comment from:

@colinrotherham colinrotherham requested a review from a team as a code owner July 13, 2023 12:38
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3956 July 13, 2023 12:39 Inactive
Base automatically changed from tests-on-windows to main July 17, 2023 07:58
@colinrotherham
Ensure package export Node.js v12.18 test doesn’t use --conditions
e7130cc 
We’re likely to add more package export matrix combinations in future

But the flag `--conditions` was only added in Node.js v12.19.0

So rather than do the hard job to “opt out” Node.js 12.18.0 from _every_ incompatible matrix combination, let’s just “opt in” to the package export tests we know will run
@colinrotherham
Skip cache “Restore dependencies” for package export tests
5b5d364
@colinrotherham
Add Node.js v20 to package export tests
9a9f69a 
Node.js v20 reaches LTS in October 2023 so good to test early
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3956 July 17, 2023 08:15 Inactive
@colinrotherham colinrotherham added github_actions Pull requests that update GitHub Actions code and removed github-actions labels Jul 18, 2023
@colinrotherham colinrotherham changed the title Run GitHub Actions export tests on Node.js v20 Add GitHub Actions export tests for Node.js v20 Jul 18, 2023
@colinrotherham
Copy link
Contributor Author

@36degrees This PR removes the unnecessary node_modules cache restoration step we talked about

@colinrotherham colinrotherham merged commit 91d0a5d into main Aug 1, 2023
@colinrotherham colinrotherham deleted the tests-on-node-20 branch August 1, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@36degrees 36degrees 36degrees approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colinrotherham @36degrees @govuk-design-system-ci