Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix govuk-colour deprecation message mismatch #3586

Merged
merged 1 commit into from
May 5, 2023
Merged

Fix govuk-colour deprecation message mismatch #3586

merged 1 commit into from
May 5, 2023

Conversation

querkmachine
Copy link
Member

Fixes a couple of minor issues with the deprecation message from #3576:

  • The warning suppression key in the message was wrong.
  • The warning didn't name the function with the deprecated parameter.

@querkmachine querkmachine self-assigned this May 5, 2023
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3586 May 5, 2023 16:19 Inactive
@querkmachine querkmachine merged commit 15a78ed into main May 5, 2023
@querkmachine querkmachine deleted the remove-compat-mode-legacy-colours branch May 5, 2023 16:25
romaricpascal pushed a commit that referenced this pull request May 18, 2023
@querkmachine
Merge pull request #3586 from alphagov/remove-compat-mode-legacy-colours
3110205 
Fix `govuk-colour` deprecation message mismatch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenatgov owenatgov owenatgov approved these changes

@36degrees 36degrees 36degrees approved these changes

Assignees

@querkmachine querkmachine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@querkmachine @36degrees @owenatgov @govuk-design-system-ci