Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new brand colour for DSIT #3523

Closed
wants to merge 2 commits into from

Conversation

beccapearce
Copy link
Contributor

No description provided.

@beccapearce beccapearce marked this pull request as ready for review April 18, 2023 13:16
@querkmachine
Copy link
Member

Good morning! Thanks for the contribution!

Unfortunately, you've caught us right at the start of a code freeze, as we're preparing to release a new version of GOV.UK Frontend. As such, this PR is unlikely to be merged and released for quite a while as part of our substantial v5 release.

We're also currently reviewing what organisation colours we ship and the process by which we update them. That work is also likely to go out in v5.

I've seen that you've opened a similar change in GOV.UK Publishing Components too. Hopefully that will work for your needs in the meantime.

@colinrotherham
Copy link
Contributor

I've rebased this PR with main to resolve srcpackages/govuk-frontend/src conflicts

//cc @querkmachine

@querkmachine
Copy link
Member

Note: You can follow on with the aforementioned organisation colour refresh work here.

@querkmachine
Copy link
Member

Hi there! Sorry for the long wait on this one.

We've decided we would prefer to batch organisation colour changes into our larger organisation colour update in #3407. In that PR, we're using the colours that (to the best of our knowledge) have been ascribed to each department by Design102 to try and enforce consistency, rather than having individual departments raise their own PRs.

As such, I'm going to close this PR for now, as it will be largely superceded by this other work. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants