-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contribution docs on adding component configuration options #3387
Conversation
We should still re-visit this, it's useful But will need to catch up with: |
The documentation here has since fallen out of date with subsequent changes to JavaScript architecture. As I wasn't involved in those updates and don't particularly have knowledge of what they are, I'm encouraging someone more familiar to update this in my stead. If it doesn't get picked up in a reasonable amount of time, I'll likely close this off instead. |
9029b65
to
e5b8a06
Compare
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 78b0795 |
@querkmachine I've given it a rapid work-in-progress refresh, something along these lines? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a neat piece of doc! 🙌🏻 I'd be keen to merge it as it is and add some extra information around typing the configuration in a separate PR (as we probably need to think if the info fits here or in a more generic using-types
piece of docs).
@colinrotherham @querkmachine Do you think there's anything holding it from being merged? If not, let's press that green button 😊
@romaricpascal Just a double check over my quick edits? Aware that lots of the examples given will fail due to missing JSDoc though, should we include it? Will also need a big update once we fix how components set up their options after #4230 |
@romaricpascal It's been a while so I'm definitely not sure of how accurate parts of it are at this point, but better to have something that we can iterate upon rather than sitting on it for much longer. |
Co-authored-by: CAAshworth <[email protected]>
Co-authored-by: CAAshworth <[email protected]>
e5b8a06
to
f408dc7
Compare
f408dc7
to
78b0795
Compare
Going to merge this on the basis that having something to iterate upon is probably better than letting this languish and grow outdated again. |
I noticed yesterday that, although we've seemingly settled on a method of adding configuration options (including localisation strings) to components, we had only documented how to use the ones we added from an end user's perspective.
Here's some scratchy documentation on how to add new configuration options and guidelines for naming them.