Adding optional id attribute to button component #3344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
querkmachine
added
feature request
|
Thanks for contributing this! It looks good to me, just needs a changelog entry added if you can. If you aren't sure or don't feel comfortable writing one, just say so and someone on the team can handle it. |
Changelog entry added |
querkmachine
approved these changes
Mar 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Not being able to have IDs on buttons has caught me out a couple of times recently, and it seems to be catching other people out as well based on this issue - #2999
This PR adds an optional id attribute to the button nunjucks macro
Happy to address any feedback and comments