Add support for localisation via JavaScript configuration to Accordion component #2826
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to two issues, #2802 and #2698, as I couldn't find a way to cleanly separate them.
initAll
function to passoptions.accordion
into the accordion initialisation.config
parameter (defaults to an empty object).config
parameter.initAll
with a custom configuration.mergeConfig
function to ensure that it supports empty objects.Todo
#2802 includes a task to ensure that "Data attribute translations take priority over JS translations, if both provided"
This is partially covered by the configuration merging function's unit tests, though that function also doesn't make an explicit distinction between configuration passed from data-* attributes and those from JavaScript. Do we feel like we need to explicitly test for parameter ordering?