Avoid duplicated --error class on character count
#2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The character count is adding the `--error` modifier class when there is an error message passed, but as part of a call to the textarea component which is already handling this for us using similar logic: https://github.com/alphagov/govuk-frontend/blob/8f8fa6f9a64753f4bc3c36328c6fdb0539cbb52c/src/govuk/components/textarea/template.njk#L40 As a result, when an error message is passed we currently end up with duplicated `--error` modifier classes on the textarea: ```html <textarea class="govuk-textarea govuk-textarea--error govuk-js-character-count govuk-textarea--error" id="exceeding-characters" name="exceeding" rows="5" aria-describedby="exceeding-characters-info exceeding-characters-error"> </textarea> ``` Remove the logic to add the `--error` modifier class from the character count component and leave it to the textarea component to handle this.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2821
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2821
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The character count is adding the
--errormodifier class when there is an error message passed, but as part of a call to the textarea component which is already handling this for us using similar logic:govuk-frontend/src/govuk/components/textarea/template.njk
Line 40 in 8f8fa6f
As a result, when an error message is passed we currently end up with duplicated
--errormodifier classes on the textarea:Remove the logic to add the
--errormodifier class from the character count component and leave it to the textarea component to handle this.