Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow localisation of content licence and copyright notices in Footer #2702

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

querkmachine
Copy link
Member

This are the bare minimum changes needed for enable localisation of the Footer component's content licence and copyright notices. In this case, it is assumed that an Open Government Licence (OGL) and Crown copyright are still being used, and that the notices are only being translated into another language.

This differs slightly from the internationalisation spike work, as I've split the contentLicence and copyright parameters into html and text versions to facilitate extending them with more options, as described below.


Issues #1290 and #1291 originally asked that it be possible to remove the OGL and Crown graphics. This hasn't been done in this PR, as it isn't strictly needed for the current localisation work and (for the most part) public-facing GOV.UK services will have been made available under OGL and Crown copyright.

I've created a version of this work with more customisation options, including changing/removing the Crown copyright URL and removing the licence/copyright graphics, as a separate branch. You can compare those branches here. Whether we consider these changes necessary or not is up for discussion!

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2702 July 15, 2022 14:09 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2702 July 15, 2022 14:11 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2702 July 22, 2022 12:34 Inactive
@vanitabarrett
Copy link
Contributor

This PR makes sense to me (although needs tests and a Changelog entry to make it 'release ready' - aware it's still in draft). I'm happy to do just what's needed to enable internationalisation, although can see benefits of the other approach too. If we go with this PR, do you think it would then involve a breaking change to introduce the ability to completely override the logo etc too?

@querkmachine
Copy link
Member Author

@vanitabarrett I don't think anything in this PR would block us expanding it to include the other options at a later date.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2702 July 22, 2022 15:18 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2702 July 22, 2022 15:22 Inactive
@querkmachine
Copy link
Member Author

I've added a changelog entry but was a little unsure of how to focus it (as 'customisation', as 'localisation', as 'translation'), as it can now be changed, but still practically has to be OGL and Crown copyright.

Can you give an expert opinion, @claireashworth?

@querkmachine querkmachine marked this pull request as ready for review July 22, 2022 15:33
Copy link
Contributor

@claireashworth claireashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the focus as localisation seems sensible to me. If the focus is customisation we should refer to the information from the National Archives as they own/manage the licence and copyright.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2702 July 22, 2022 16:24 Inactive
Copy link
Contributor

@vanitabarrett vanitabarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works well, just a few comments about expanding the documentation/examples

src/govuk/components/footer/footer.yaml Outdated Show resolved Hide resolved
src/govuk/components/footer/footer.yaml Outdated Show resolved Hide resolved
src/govuk/components/footer/template.test.js Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2702 July 25, 2022 16:24 Inactive
@vanitabarrett
Copy link
Contributor

Looks good to me! Would be great to get the commits tidied up/squashed a bit before merging.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2702 July 26, 2022 09:08 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2702 July 26, 2022 09:13 Inactive
Copy link
Contributor

@vanitabarrett vanitabarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants