Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate .govuk-header__navigation--no-service-name #2694

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

querkmachine
Copy link
Member

Marks the .govuk-header__navigation--no-service-name as having been deprecated in our Sass and changelog, as per #2216.

The class is not documented in our docs or review app, serves a dubiously useful use case, and I couldn't find any instances of it being used when searching public GitHub repos, with it only appearing in forks of Frontend and automatically-generated documentation.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2694 July 14, 2022 11:31 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2694 July 14, 2022 11:32 Inactive
@querkmachine querkmachine requested a review from a team July 14, 2022 11:33
@querkmachine querkmachine self-assigned this Jul 14, 2022
@querkmachine querkmachine linked an issue Jul 15, 2022 that may be closed by this pull request
3 tasks
@owenatgov owenatgov self-requested a review July 15, 2022 10:08
Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the job 👍🏻

@querkmachine querkmachine merged commit 23c8e68 into main Jul 15, 2022
@querkmachine querkmachine deleted the kg-deprecate-no-service-name branch July 15, 2022 10:23
@querkmachine querkmachine mentioned this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate govuk-header__navigation--no-service-name class
3 participants