Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix footer alignment with grid classes and add width macro option #2462

Merged
merged 10 commits into from
Dec 9, 2021
Merged

Fix footer alignment with grid classes and add width macro option #2462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fd9e9b1
Remove assumption that two sections should be two-third/one-third
Dec 3, 2021
2ffea25
Remove flex and set default section width to full width
Dec 8, 2021
1999234
Add new `width` macro option
Dec 8, 2021
8bc5457
Make list margins above and below equal
Dec 6, 2021
6840a0a
Rename and update footer YAML examples
Dec 8, 2021
d4b179a
Update full page examples with footer
Dec 6, 2021
83b173f
Enhance alignment examples
Dec 8, 2021
be34d02
Add to Changelog
Dec 6, 2021
69dc476
Mark hidden examples as hidden
Dec 8, 2021
e745aa6
Remove unnecessary additional component query in tests
Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,20 @@ To fix this error, replace any imports of `node_modules/govuk-frontend/govuk/cor

This change was introduced in [pull request #22463: Move template styles from `core` to `objects` layer](https://github.com/alphagov/govuk-frontend/pull/2463).

#### Check your footer displays as expected

We’ve made some fixes to the alignment of columns within the footer component, so they align with our grid. We've also removed the logic that assumes a 2-section layout displays as a 'two-thirds and one-third' layout. Footer sections now display as full-width by default.

If you're using the Nunjucks macros, check your footer displays as expected and use the `width` macro option to set the width you want for each section.

If you're not using the Nunjucks macros, check your footer displays as expected and use the standard Design System grid classes on the `govuk-footer__section` element to set the width. For example:

```html
<div class="govuk-footer__section govuk-grid-column-two-thirds">...</div>
```

This change was introduced in [pull request #2462: Fix footer alignment with grid classes and add `width` macro option](https://github.com/alphagov/govuk-frontend/pull/2462).

### Optional changes

We've recently made some other changes to GOV.UK Frontend. While these are not breaking changes, implementing them will make your service work better.
Expand Down
Loading