Remove deprecated govuk-main-wrapper and govuk-main-wrapper--l mixins
#2385
Conversation
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2385
vanitabarrett
changed the title
main-wrapper and main-wrapper--l mixins
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2385
|
@EoinShaughnessy I've added a draft entry in the Changelog for this change. Do you want to take a look here or should I copy it into the v4.0.0 draft release notes doc? |
vanitabarrett
changed the title
main-wrapper and main-wrapper--l mixinsgovuk-main-wrapper and govuk-main-wrapper--l mixins
vanitabarrett
force-pushed
the
remove-main-wrapper-mixins
branch
from
2d8f953 to
1d13a59
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2385
…r--l mixins In ade03d4 we deprecated the `govuk-main-wrapper` and `govuk-main-wrapper--l` mixins because we didn't think they were useful. This commit removes those mixins. Note: the classes remain, but the mixins are being removed.
vanitabarrett
force-pushed
the
remove-main-wrapper-mixins
branch
from
1d13a59 to
c77b2cc
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2385
|
@vanitabarrett Content looks good! I can copy it into the draft doc once we've resolved the 2 small comments I've added. |
|
@vanitabarrett Do we want to change the title here, so the release note doesn't read like "This was added in [Remove deprecated...]'? Same kind of rationale as for the change to #1963. |
vanitabarrett
force-pushed
the
remove-main-wrapper-mixins
branch
from
c77b2cc to
8753d1c
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2385
|
@EoinShaughnessy Thanks for those comments - I've made the changes you've suggested. On the title of the pull request, I'm unsure about renaming to use 'avoid' for work like this. Maybe it's just me, but 'avoid' suggests you shouldn't do a thing but you can if you really need to. The work we're doing is to remove these mixins (if someone were to update to v4.0.0 and try to use them, their code would throw an error). So I'm not sure 'avoid' is a strong enough message? Writing 'avoid deprecated ... etc' also implies the things are still deprecated, but they've actually been removed completely. I'm almost tempted to stick with the title as it is for now and see if anyone picks up on it in research? |
|
@vanitabarrett Yeah, +1 to sticking with the title and seeing what users might say. 👍🏻 |
Fixes #1379 (also see here for details of how this is a breaking change for users)
In ade03d4 we deprecated the
main-wrapperandmain-wrapper--lmixins because we didn't think they were useful.This PR removes those mixins. Note: the classes remain, but the mixins are being removed.