-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update accordion macros about summary line change #2313
Conversation
5c54cfc
to
44579b0
Compare
Content has passed internal review. Will now send it for pre-i. |
Content has passed pre-i. Will now send it for 2i. |
73ea4b4
to
169811f
Compare
@hannalaakso Content has passed 2i. Can you approve? I won't merge until we're ready to release the iteration. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, just needs rebasing
9b529e1
to
af95abd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just blocking this from being merged until we get a chance to chat about my comments above (although they aren't necessarily blocking).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EoinShaughnessy Thanks for addressing my feedback! Your two proposed changes (below) just need to be committed and then this can be merged 👍
8949351
to
2e76fb4
Compare
@hannalaakso Thanks for reviewing! Do we need to wait for 4.0 release before merging? |
@EoinShaughnessy We've started merging 4.0 things to main now so this can be merged in 👍 (for anyone's who's interested, we're putting a separate process in place if we ever find ourselves in a situation where we need to publish any more 3.x.x releases when 4.0 changes have already been merged into main). |
Addresses #2310.
What we've added
This PR adds content to the following parameters' Descriptions in the macros table for the accordion component:
summary.html
heading.html
Why we've added it
This new content tells users the summary line can only contain phrasing content. This is because using non-phrasing content will result in invalid HTML.
We've also advised users to: