-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task list component #2261
Task list component #2261
Conversation
One of the questions for this component is what do we call the param that holds the array of things with statuses? Our initial instinct was to use However I've done a quick check of what existing components use: Accordion: Based on this, I wonder whether it would be more consistent to use |
GDS wrote a summary back in 2017 of some of the pros and cons of using Tables, Definition lists and Lists. |
We might want to add |
I've switched to
|
@36degrees I think I’ve made all the changes - thanks for spotting them all! 👏 Would you mind approving the test workflows, and checking and re-reviewing the code? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good – thanks for all your hard work on this @frankieroberto 🙌🏻
A few final things to sort:
- We need to add a changelog entry to tell users know about this exciting new component!
- Ideally we'd improve the commit structure, ideally reducing to a small number of meaningful commits and removing the merges. Is that something you'd be comfortable doing? I'm happy to do this for you if you'd prefer.
- It'd be good to add some more tests to cover the various different macro options to ensure they're working as intended. This is a little laborious, so I'm happy to create an issue for our team to do this in a follow up PR unless you're particularly keen to be involved?
e4c96a1
to
9eea709
Compare
9eea709
to
fac0e99
Compare
Discussed this with @frankieroberto and have raised an issue for us to do this (#3828). I believe the other points have been addressed. This just needs a second review and then we can get it merged – @owenatgov would you be happy to take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My final extremely pedantic review comment is that the hint
param still needs a description. Once that's done then I'm more than happy to approve this.
fac0e99
to
b1e7c7d
Compare
Fixed (squashed the commit and force-pushed) - thanks for spotting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done everyone 🎉
Following the release of [GOV.UK Design System v5.0](https://github.com/alphagov/govuk-design-system/milestone/16), govuk-components v5.0.0 will be released. The headline features are: * support for GOV.UK Design System v5.0 * inclusion of [the task list component](alphagov/govuk-frontend#2261) #425 * all new link helpers #419 * update header to use new SVG which combines the crown and the GOV.UK test #466 Release notes will be drafted in #469.
This adds a new component for the existing Task list pattern, which is widely in use by services. (At the moment, this requires custom code, such as is included in the GOV.UK Prototyping Kit).
The component can be used to create a single task list. Multiple task lists can be added, with headings, to create a task list page, where there are groups of related tasks.
This component was developed collaboratively by the cross-government Task list group, based upon the research and experience of teams using the pattern in live services.
Some changes were made based upon feedback from service teams:
Thanks to
@ImranH-GDS @owenatgov @MK-NG @steve-oconnor @Dawdre @lfdebrux @frankieroberto @christopherthomasdesign @calvin-lau-sig7 @36degrees @timpaul @paulrobertlloyd and many others!