Add no-underline mixin and modifier class #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fairly common thing for service teams to need to implement, and they’ll often do it using `text-decoration` which, as a shorthand property, results in the `text-decoration-thickness` being reset to auto for the hover state. Provide a mixin and class which includes the correct behaviour. Add it to the ‘links’ examples page. # Conflicts: # src/govuk/core/_links.scss
IE11 does not support the CSS Text Decoration Module Level 3 ‘text-decoration styling’ properties [1] [2], and only recognises `text-decoration` as a regular property with values of none, underline, etc – as defined in CSS2 [3]. As such, using `text-decoration-line` to ‘unset’ the underline does not work in IE11. We want to avoid re-setting the `text-decoration` property because when treated as shorthand (in browsers that support `text-decoration-styling` this resets the `text-decoration-thickness` property to `auto`. Instead, use `:not(:hover):not(:active)` to remove the text-decoration except when hovered/active. `:not` is supported in IE9 and above. This means that the `no-underline` mixin / modifier will have no effect in IE8. Unfortunately the pseudo-class plugin we use to display links in different states does not correctly handle `:not` when used like this, so the examples in the links page do not render correctly. Revert the changes to this example, adding a simpler example instead. [1]: https://www.w3.org/TR/css-text-decor-3/#text-decoration [2]: https://caniuse.com/text-decoration [3]: https://www.w3.org/TR/2009/CR-CSS2-20090908/text.html#propdef-text-decoration
36degrees
force-pushed
the
no-underline-link-mixin
branch
from
615d420
to
ff0f328
Compare
vanitabarrett
approved these changes
Apr 30, 2021
12 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly common thing for service teams to need to implement, and they’ll often do it using
text-decorationwhich, as a shorthand property, results in thetext-decoration-thicknessbeing reset to auto for the hover state.Provide a mixin and class which includes the correct behaviour. Add it to the ‘links’ examples page.
The underlying styles make use of
:not, which means that theno-underlinemixin / modifier will have no effect in IE8 which does not support:not.Screenshot
Link without underline
Link without underline (hovered / active)
Split out from #2183.
Closes #2189