Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add underline to crown copyright link in footer #2212

Merged
merged 2 commits into from
Apr 30, 2021

Conversation

36degrees
Copy link
Contributor

@36degrees 36degrees commented Apr 29, 2021

To be consistent with all of the other links in the footer.

Before

Screenshot 2021-04-29 at 17 52 36

After

Screenshot 2021-04-29 at 17 52 27

Split out from #2183.

To be consistent with all of the other links in the footer.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2212 April 29, 2021 16:53 Inactive
Copy link
Member

@lfdebrux lfdebrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Should this be in the changelog?

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2212 April 30, 2021 10:52 Inactive
@36degrees 36degrees merged commit 964604d into master Apr 30, 2021
@36degrees 36degrees deleted the footer-crown-copyright-link branch April 30, 2021 11:00
@36degrees 36degrees added this to the v3.12.0 milestone May 5, 2021
@36degrees 36degrees mentioned this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants