Remove user-agent default 2px horizontal margins on buttons in Safari #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari’s default user-agent styles for buttons include a 2px margin on the left and right. Explicitly set the left and right margin to 0 rather than relying on the default user-agent styles having a margin of 0 to ensure consistent alignment and spacing across browsers.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2133
36degrees
changed the title
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2133
vanitabarrett
approved these changes
Feb 3, 2021
Merged
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari’s default user-agent styles for buttons include a 2px margin on the left and right. Explicitly set the left and right margin to 0 rather than relying on the default user-agent styles having a margin of 0 to ensure consistent alignment and spacing across browsers.
Before
After