Wrap notification banner content at 2/3 grid width #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintain shorter line-lengths when the notification banner is full width by wrapping at the same point a 2/3 column ends.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2042
|
@36degrees do you think a similar thing should be applied to the error summary? |
36degrees
requested review from
vanitabarrett
and removed request for
hannalaakso
christopherthomasdesign
approved these changes
Nov 27, 2020
Make it less likely that we update the padding without also updating the calculation by abstracting the padding to a variable.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2042
vanitabarrett
approved these changes
Nov 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintain shorter line-lengths when the notification banner is full width by wrapping at the same point a 2/3 column ends.
👉🏻 See examples
With increased root text size:
With a custom page size and gutter width:
Fixes #2033