Explicitly set the text colour for notification banner content, rather than using the user-agent default text colour #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2036
The notification banner content currently uses the user agent default text colour. This means that for users who have not changed their user agent default text colour, the text will be true black (`#000000`) rather than the ‘GOV.UK’ black we specify in the colour palette (`#0b0c0c`). It also means that if a user has changed their default text colour, but has not chosen to override colours, depending on the user’s prefered colour scheme the text may have low contrast or be invisible. For example, my Firefox instance is configured to use white text on a blue background. The notification banner is therefore white-on-white, and thus invisible. As I understand it, this is as a ‘failure of Success Criterion 1.4.3, 1.4.6 and 1.4.8 due to specifying foreground colors without specifying background colors or vice versa’ [1]. Set the text colour of the `govuk-notification-banner__content` element using the `govuk-text-colour` mixin to fix this. [1]: https://www.w3.org/TR/WCAG20-TECHS/F24.html
36degrees
force-pushed
the
notification-banner-text-colour
branch
from
311df07
to
4a350d9
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2036
vanitabarrett
approved these changes
Nov 25, 2020
36degrees
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notification banner content currently uses the user agent default text colour.
This means that for users who have not changed their user agent default text colour, the text will be true black (
#000000) rather than the ‘GOV.UK’ black we specify in the colour palette (#0b0c0c).It also means that if a user has changed their default text colour, but has not chosen to override colours, depending on the user’s prefered colour scheme the text may have low contrast or be invisible.
For example, my Firefox instance is configured to use white text on a blue background:
The notification banner is therefore white-on-white, and thus invisible:
As I understand it, this is as a ‘failure of Success Criterion 1.4.3, 1.4.6 and 1.4.8 due to specifying foreground colors without specifying background colors or vice versa’.
Set the text colour of the
govuk-notification-banner__contentelement using thegovuk-text-colourmixin to fix this:Fixes #2037