Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style notification banner #1982

Merged
merged 6 commits into from
Oct 23, 2020

Conversation

vanitabarrett
Copy link
Contributor

@vanitabarrett vanitabarrett commented Oct 9, 2020

Temporarily cherrypicks commits from #1977.
Please only review commits solely authored by me - others will be removed before merging into feature branch

Why

Following on from #1934 and #1977, add the styling for the notification banner component.

Full designs can be found here: https://design-system-mess.herokuapp.com/notification-banner-colour-heading

What

  • Styling added for notification banner component
  • Links within the notification banner use a govuk-notification-banner__link class
  • Added additional examples to show links within error and success notification banners
  • Added success and error link style mixins, and applied them to the error summary component too

@vanitabarrett vanitabarrett linked an issue Oct 9, 2020 that may be closed by this pull request
4 tasks
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 9, 2020 13:54 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 9, 2020 15:03 Inactive
@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from 70ae3e2 to 81ae671 Compare October 9, 2020 15:15
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 9, 2020 15:15 Inactive
@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from 81ae671 to 68177cb Compare October 9, 2020 15:31
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 9, 2020 15:31 Inactive
@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from 68177cb to cb1bf6c Compare October 13, 2020 10:32
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 13, 2020 10:33 Inactive
@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from cb1bf6c to 2179c75 Compare October 13, 2020 10:44
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 13, 2020 10:44 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 13, 2020 15:04 Inactive
@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from 08e697f to b628701 Compare October 13, 2020 15:07
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 13, 2020 15:07 Inactive
@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from b628701 to 4468703 Compare October 13, 2020 15:10
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 13, 2020 15:11 Inactive
@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from 4468703 to cf20652 Compare October 14, 2020 12:07
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 14, 2020 12:07 Inactive
@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from cf20652 to 951406c Compare October 14, 2020 12:14
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 14, 2020 12:15 Inactive
@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from 951406c to 5badd54 Compare October 14, 2020 13:10
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 14, 2020 13:10 Inactive
@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from 5badd54 to fce5f5f Compare October 14, 2020 13:41
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 14, 2020 13:41 Inactive
@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from fce5f5f to 165c8b7 Compare October 14, 2020 14:32
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 14, 2020 14:32 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 14, 2020 15:39 Inactive
@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from 8d59335 to 30ff04f Compare October 15, 2020 08:40
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 15, 2020 08:40 Inactive
@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from 9ec80bd to 3dfb13e Compare October 21, 2020 10:43
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 21, 2020 10:43 Inactive
@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from 3dfb13e to 90cd260 Compare October 21, 2020 10:50
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 21, 2020 10:50 Inactive
@christopherthomasdesign christopherthomasdesign dismissed their stale review October 21, 2020 13:40

Spacing updated, looks good to me

@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from 90cd260 to 61d83a4 Compare October 22, 2020 09:33
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 22, 2020 09:33 Inactive
Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @vanitabarrett 👏

@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from 61d83a4 to 231b885 Compare October 23, 2020 08:27
@vanitabarrett vanitabarrett changed the base branch from master to feature/notification-banner October 23, 2020 08:27
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 23, 2020 08:27 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 23, 2020 08:46 Inactive
@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from 45ea974 to 231b885 Compare October 23, 2020 09:26
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 23, 2020 09:26 Inactive
@vanitabarrett vanitabarrett changed the base branch from feature/notification-banner to master October 23, 2020 09:27
@vanitabarrett vanitabarrett force-pushed the style-notification-banner branch from 231b885 to 074a7c5 Compare October 23, 2020 09:52
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1982 October 23, 2020 09:52 Inactive
@vanitabarrett vanitabarrett changed the base branch from master to feature/notification-banner October 23, 2020 09:57
Vanita Barrett added 2 commits October 23, 2020 10:58
As part of the notification banner work, we introduced a new govuk-link-style-error mixin to automatically apply error colours to links (including visited and hover styles).

We should apply these styles to the error summary component so things are consistent.
The error summary doesn't currently have visited/hover styles for links, which isn't great, so this change adds those styles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add styling for notification banner component
6 participants