-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style notification banner #1982
Merged
vanitabarrett
merged 6 commits into
feature/notification-banner
from
style-notification-banner
Oct 23, 2020
Merged
Style notification banner #1982
vanitabarrett
merged 6 commits into
feature/notification-banner
from
style-notification-banner
Oct 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 9, 2020 13:54
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 9, 2020 15:03
Inactive
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 9, 2020 15:15
70ae3e2
to
81ae671
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 9, 2020 15:15
Inactive
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 9, 2020 15:31
81ae671
to
68177cb
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 9, 2020 15:31
Inactive
36degrees
reviewed
Oct 13, 2020
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 13, 2020 10:32
68177cb
to
cb1bf6c
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 13, 2020 10:33
Inactive
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 13, 2020 10:44
cb1bf6c
to
2179c75
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 13, 2020 10:44
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 13, 2020 15:04
Inactive
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 13, 2020 15:07
08e697f
to
b628701
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 13, 2020 15:07
Inactive
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 13, 2020 15:10
b628701
to
4468703
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 13, 2020 15:11
Inactive
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 14, 2020 12:07
4468703
to
cf20652
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 14, 2020 12:07
Inactive
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 14, 2020 12:14
cf20652
to
951406c
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 14, 2020 12:15
Inactive
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 14, 2020 13:10
951406c
to
5badd54
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 14, 2020 13:10
Inactive
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 14, 2020 13:41
5badd54
to
fce5f5f
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 14, 2020 13:41
Inactive
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 14, 2020 14:32
fce5f5f
to
165c8b7
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 14, 2020 14:32
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 14, 2020 15:39
Inactive
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 15, 2020 08:40
8d59335
to
30ff04f
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 15, 2020 08:40
Inactive
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 21, 2020 10:43
9ec80bd
to
3dfb13e
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 21, 2020 10:43
Inactive
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 21, 2020 10:50
3dfb13e
to
90cd260
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 21, 2020 10:50
Inactive
christopherthomasdesign
dismissed
their stale review
October 21, 2020 13:40
Spacing updated, looks good to me
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 22, 2020 09:33
90cd260
to
61d83a4
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 22, 2020 09:33
Inactive
hannalaakso
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @vanitabarrett 👏
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 23, 2020 08:27
61d83a4
to
231b885
Compare
vanitabarrett
changed the base branch from
master
to
feature/notification-banner
October 23, 2020 08:27
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 23, 2020 08:27
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 23, 2020 08:46
Inactive
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 23, 2020 09:26
45ea974
to
231b885
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 23, 2020 09:26
Inactive
vanitabarrett
changed the base branch from
feature/notification-banner
to
master
October 23, 2020 09:27
The header and links change colour based on if the notification banner is type: notification, success or error.
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 23, 2020 09:52
231b885
to
074a7c5
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1982
October 23, 2020 09:52
Inactive
vanitabarrett
changed the base branch from
master
to
feature/notification-banner
October 23, 2020 09:57
As part of the notification banner work, we introduced a new govuk-link-style-error mixin to automatically apply error colours to links (including visited and hover styles). We should apply these styles to the error summary component so things are consistent. The error summary doesn't currently have visited/hover styles for links, which isn't great, so this change adds those styles.
vanitabarrett
force-pushed
the
style-notification-banner
branch
from
October 23, 2020 09:58
074a7c5
to
4ab8631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily cherrypicks commits from #1977.
Please only review commits solely authored by me - others will be removed before merging into feature branch
Why
Following on from #1934 and #1977, add the styling for the notification banner component.
Full designs can be found here: https://design-system-mess.herokuapp.com/notification-banner-colour-heading
What
govuk-notification-banner__link
class