Update v3.9.0 (unreleased) changelog for style #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1948
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1948
36degrees
reviewed
Sep 8, 2020
| menuButtonLabel: "Custom menu label" | ||
| }) }} | ||
| ``` | ||
| ### Fixes |
There was a problem hiding this comment.
This section appears to be duplicated.
There was a problem hiding this comment.
I think (?) I just accidentally fixed this when I rebased... let me know if not though!
There was a problem hiding this comment.
Ah wait no sorry, it's still there... I'll fix
There was a problem hiding this comment.
Should be fixed now - thanks for spotting!
m-green
force-pushed
the
edit-3.9.0-release-note
branch
from
d618f15
to
b92172b
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1948
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1948
3 tasks
hannalaakso
reviewed
Sep 8, 2020
CHANGELOG.md
Outdated
| You can now add a prefix or suffix element to the text input to help users enter things like currencies and measurements. | ||
| You can now [use prefixes and suffixes in the text input component](https://design-system.service.gov.uk/components/text-input/#prefixes-and-suffixes) to help users enter things like currencies and measurements. | ||
|
|
||
| This was added in [pull request #1269: Add input prefix and suffix](https://github.com/alphagov/govuk-design-system/pull/1269/files). Thanks to [@simonwhatley](https://github.com/simonwhatley) and the GOV.UK Coronavirus Services Team. |
CHANGELOG.md
Outdated
|
|
||
| This was added in [pull request #1918: Add new brand colour for FCDO](https://github.com/alphagov/govuk-frontend/pull/1918). | ||
| - [#1905: Set navigation and mobile menu labels of the header component with new options](https://github.com/alphagov/govuk-frontend/pull/1905) | ||
| - [#1943: Change header menu button label](https://github.com/alphagov/govuk-frontend/pull/1943) |
There was a problem hiding this comment.
This could be
- #1943: Change header menu button label - thanks to @domoscargin for raising this issue
CHANGELOG.md
Outdated
|
|
||
| #### Set navigation and mobile menu labels of the header with new options | ||
| #### Test if your HTML matches GOV.UK Frontend |
There was a problem hiding this comment.
This is just a suggestion but I would be tempted to position this before the header features as it feels like the more important feature.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1948
m-green
force-pushed
the
edit-3.9.0-release-note
branch
from
2bd188a
to
8e55dfc
Compare
hannalaakso
approved these changes
Sep 8, 2020
|
@hannalaakso This has been 2i'd now - no changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the v3.9.0 (unreleased) changelog for style and readability.