Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accordion underline hover state being removed when hovering plus/minus symbol #1778

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Fix accordion underline hover state being removed when hovering plus/minus symbol #1778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b81e5a
Append icon to accordion button, not heading
36degrees Mar 31, 2020
0aa5d51
Add to changelog
36degrees Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Fixes

- [Pull request #1765: Import textarea from character count](https://github.com/alphagov/govuk-frontend/pull/1765).
- [Pull request #1778: Fix accordion underline hover state being removed when hovering plus/minus symbol](https://github.com/alphagov/govuk-frontend/pull/1778).

## 3.6.0 (Feature release)

Expand Down
2 changes: 1 addition & 1 deletion src/govuk/components/accordion/accordion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ Accordion.prototype.initHeaderAttributes = function ($headerWrapper, index) {
icon.className = this.iconClass
icon.setAttribute('aria-hidden', 'true')

$heading.appendChild(icon)
$button.appendChild(icon)
}

// When section toggled, set and store state
Expand Down