-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collapseOnMobile breadcrumbs flag #1754
Add collapseOnMobile breadcrumbs flag #1754
Conversation
3cb5960
to
b923668
Compare
b923668
to
3c9a219
Compare
As discussed on Slack, from talking to the team we’re not 100% sure about the touch target size changes at the minute because:
We've agreed to just ship the behaviour that hides everything between the first and last breadcrumb, and create an issue to review the touch target size separately (with yourself and the designer that worked on it). |
Raised a separate issue to look at the breadcrumb touch target size: #1817 |
When this flag is passed, the breadcrumbs component on mobile collapses down to the first and last item only
98486ba
to
6964eaf
Compare
Updated PR to remove touch target change but keep:
|
6964eaf
to
f6a9042
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @vanitabarrett 👍
This feature has been ported to govuk-frontend alphagov/govuk-frontend#1754
This feature has been ported to govuk-frontend alphagov/govuk-frontend#1754
This feature has been ported to govuk-frontend alphagov/govuk-frontend#1754
This feature has been ported to govuk-frontend alphagov/govuk-frontend#1754
This feature has been ported to govuk-frontend alphagov/govuk-frontend#1754
This feature has been ported to govuk-frontend alphagov/govuk-frontend#1754
This feature has been ported to govuk-frontend alphagov/govuk-frontend#1754
This feature has been ported to govuk-frontend alphagov/govuk-frontend#1754
This feature has been ported to govuk-frontend alphagov/govuk-frontend#1754
This feature has been ported to govuk-frontend alphagov/govuk-frontend#1754
What
Adds a collapseOnMobile flag to the breadcrumbs component. When set to true, this flag means the breadcrumb component will:
Note: this change has been implemented on GOVUK and we wish to contribute this change back to the design system.
Why