Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make width-container margins more targetted to avoid specificity issues #1670

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

NickColley
Copy link
Contributor

To avoid issues with specificity when people are using their own custom width containers we can set only the properties that are required.

This also mirrors how we are setting margins in the rest of the object.

Fixes #1658

To avoid issues with specificity when people are using their own custom width containers we can set only the properties that are required.

This also mirrors how we are setting margins in the rest of the object.

Fixes #1658
@NickColley NickColley added this to the Next milestone Dec 3, 2019
@NickColley NickColley changed the title Fix width container changing header bar Make width-container margins more targetted to avoid specificity issues Dec 3, 2019
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⬅️👍➡️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

govuk-width-container mixin changes how header looks
3 participants