Update hex value for secondary text to improve contrast #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes in this PR
The secondary text colour value has been updated to improve the
constrast of components that use the ```govuk-colour("dark-grey")```
sass variable. The value has been updated from ```#6f777b``` to
```626a6e```
Fixes #1134
This reverts commit d1a1695.
Fixes in this PR
The secondary text colour value has been updated to improve the
contrast of components that use the ```govuk-colour("dark-grey")```
sass variable. The value has been updated from ```#6f777b``` to ```#626a6e```
This is a small incremental change that improves the contrast ratio from 4.56:1 to 5.51:1.
Fixes #1134
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1609
NickColley
approved these changes
Oct 9, 2019
36degrees
added a commit
that referenced
this pull request
Nov 5, 2019
This was accidentally added to the changelog for 3.3.0 after the release had been made – we've yet to release it, so it should be included in the unreleased section.
36degrees
added a commit
that referenced
this pull request
Nov 6, 2019
Move #1609 from 3.3.0 to unreleased
m-green
pushed a commit
that referenced
this pull request
Nov 13, 2019
This was accidentally added to the changelog for 3.3.0 after the release had been made – we've yet to release it, so it should be included in the unreleased section.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes in this PR
The secondary text colour value has been updated to improve the contrast of components that use the
govuk-colour("dark-grey")sass variable. The value has been updated from#6f777bto#626a6eThis is a small incremental change that improves the contrast ratio from 4.56:1 to 5.51:1.
Fixes #1134