Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent inputs ending up off screen or obscured by keyboards when linking from the error summary to inputs within a large fieldset #1570

Merged
merged 5 commits into from
Sep 19, 2019
Merged

Prevent inputs ending up off screen or obscured by keyboards when linking from the error summary to inputs within a large fieldset #1570

merged 5 commits into from
Sep 19, 2019

Commits on Sep 19, 2019

  1. Add example of address pattern to error summary 

    If you use the error summary component with our current address pattern (multiple text inputs within a fieldset), clicking on the error message for the post code scrolls to the top of the fieldset which means e.g. on iOS the postcode field ends up obscured by the keyboard.

This example demonstrates that and allows us to test for sensible behaviour.
    @36degrees
    36degrees committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    5b822cb View commit details
    Browse the repository at this point in the history

  2. Don’t scroll to legend if input could be obscured 

    Only scroll to the fieldset’s legend (instead of the label associated with the input) if the input would end up in the top half of the screen.

This should avoid situations where the input either ends up off the screen, or obscured by a software keyboard.
    @36degrees
    36degrees committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    fac0a74 View commit details
    Browse the repository at this point in the history

  3. Always scroll to legend for checkboxes and radios

    @36degrees
    36degrees committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    200b058 View commit details
    Browse the repository at this point in the history

  4. Add test coverage for new error summary logic

    @36degrees
    36degrees committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    db33439 View commit details
    Browse the repository at this point in the history

  5. Document in changelog

    @36degrees
    36degrees committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    7b27912 View commit details
    Browse the repository at this point in the history